Skip to content

Commit

Permalink
feat: trigger deprecation for AbstractDependencyProvider
Browse files Browse the repository at this point in the history
  • Loading branch information
Chemaclass committed Aug 17, 2024
1 parent f882ae5 commit 6230b7a
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Framework/AbstractDependencyProvider.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
namespace Gacela\Framework;

/**
* @deprecated in favor of AbstractProvider
* @deprecated in favor of AbstractProvider. This class will be removed in version 2.0
*/
abstract class AbstractDependencyProvider extends AbstractProvider
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ public function resolve(object|string $caller): ?AbstractProvider
/** @var ?AbstractDependencyProvider $resolved */
$resolved = $this->doResolve($caller);

if ($resolved !== null) {
trigger_deprecation('gacela-project/gacela', '1.8', sprintf(
'Use %s. %s will be removed in version 2.0',
AbstractProvider::class,
AbstractDependencyProvider::class,
));
}

return $resolved;
}

Expand Down
2 changes: 1 addition & 1 deletion tests/Unit/Framework/ClassResolver/ClassInfoTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ public function test_anonymous_class(): void
self::assertSame('\module-name@anonymous\ClassInfoTest\Factory', $actual->getCacheKey(), 'cache key');
}

public function test_anonymous_dep_pro_class(): void
public function test_anonymous_dependency_provider_class(): void
{
$dependencyProvider = new class() extends AbstractDependencyProvider {
public function provideModuleDependencies(Container $container): void
Expand Down

0 comments on commit 6230b7a

Please sign in to comment.