Move consts from final to abstract class

The aim is to reduce the complexity of the final class
gacela-project · Aug 13, 2023 · 3068bda · 3068bda
1 parent 15731e4
commit 3068bda
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 23 deletions.
diff --git a/src/Framework/Bootstrap/AbstractSetupGacela.php b/src/Framework/Bootstrap/AbstractSetupGacela.php
@@ -4,12 +4,35 @@
 
 namespace Gacela\Framework\Bootstrap;
 
+use Gacela\Framework\ClassResolver\Cache\GacelaFileCache;
 use Gacela\Framework\Config\GacelaConfigBuilder\AppConfigBuilder;
 use Gacela\Framework\Config\GacelaConfigBuilder\BindingsBuilder;
 use Gacela\Framework\Config\GacelaConfigBuilder\SuffixTypesBuilder;
 
 abstract class AbstractSetupGacela implements SetupGacelaInterface
 {
+    public const shouldResetInMemoryCache = 'shouldResetInMemoryCache';
+    public const fileCacheEnabled = 'fileCacheEnabled';
+    public const fileCacheDirectory = 'fileCacheDirectory';
+    public const externalServices = 'externalServices';
+    public const projectNamespaces = 'projectNamespaces';
+    public const configKeyValues = 'configKeyValues';
+    public const servicesToExtend = 'servicesToExtend';
+    public const plugins = 'plugins';
+    public const gacelaConfigsToExtend = 'gacelaConfigsToExtend';
+
+    protected const DEFAULT_ARE_EVENT_LISTENERS_ENABLED = true;
+    protected const DEFAULT_SHOULD_RESET_IN_MEMORY_CACHE = false;
+    protected const DEFAULT_FILE_CACHE_ENABLED = GacelaFileCache::DEFAULT_ENABLED_VALUE;
+    protected const DEFAULT_FILE_CACHE_DIRECTORY = GacelaFileCache::DEFAULT_DIRECTORY_VALUE;
+    protected const DEFAULT_PROJECT_NAMESPACES = [];
+    protected const DEFAULT_CONFIG_KEY_VALUES = [];
+    protected const DEFAULT_GENERIC_LISTENERS = [];
+    protected const DEFAULT_SPECIFIC_LISTENERS = [];
+    protected const DEFAULT_SERVICES_TO_EXTEND = [];
+    protected const DEFAULT_GACELA_CONFIGS_TO_EXTEND = [];
+    protected const DEFAULT_PLUGINS = [];
+
     /**
      * Define different config sources.
      */

diff --git a/src/Framework/Bootstrap/SetupGacela.php b/src/Framework/Bootstrap/SetupGacela.php
@@ -6,7 +6,6 @@
 
 use Closure;
 use Gacela\Framework\Bootstrap\Setup\GacelaConfigExtender;
-use Gacela\Framework\ClassResolver\Cache\GacelaFileCache;
 use Gacela\Framework\Config\GacelaConfigBuilder\AppConfigBuilder;
 use Gacela\Framework\Config\GacelaConfigBuilder\BindingsBuilder;
 use Gacela\Framework\Config\GacelaConfigBuilder\SuffixTypesBuilder;
@@ -21,28 +20,6 @@
  */
 final class SetupGacela extends AbstractSetupGacela
 {
-    public const shouldResetInMemoryCache = 'shouldResetInMemoryCache';
-    public const fileCacheEnabled = 'fileCacheEnabled';
-    public const fileCacheDirectory = 'fileCacheDirectory';
-    public const externalServices = 'externalServices';
-    public const projectNamespaces = 'projectNamespaces';
-    public const configKeyValues = 'configKeyValues';
-    public const servicesToExtend = 'servicesToExtend';
-    public const plugins = 'plugins';
-    public const gacelaConfigsToExtend = 'gacelaConfigsToExtend';
-
-    private const DEFAULT_ARE_EVENT_LISTENERS_ENABLED = true;
-    private const DEFAULT_SHOULD_RESET_IN_MEMORY_CACHE = false;
-    private const DEFAULT_FILE_CACHE_ENABLED = GacelaFileCache::DEFAULT_ENABLED_VALUE;
-    private const DEFAULT_FILE_CACHE_DIRECTORY = GacelaFileCache::DEFAULT_DIRECTORY_VALUE;
-    private const DEFAULT_PROJECT_NAMESPACES = [];
-    private const DEFAULT_CONFIG_KEY_VALUES = [];
-    private const DEFAULT_GENERIC_LISTENERS = [];
-    private const DEFAULT_SPECIFIC_LISTENERS = [];
-    private const DEFAULT_SERVICES_TO_EXTEND = [];
-    private const DEFAULT_GACELA_CONFIGS_TO_EXTEND = [];
-    private const DEFAULT_PLUGINS = [];
-
     /** @var callable(AppConfigBuilder):void */
     private $appConfigFn;