Add support for ::pc/transform in id-resolver
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylernisonoff
force-pushed
the
develop
branch
from
ae7b98a
to
1ce5b30
Compare
|
Sure, seems fine. With Pathom 3 around the corner we're probably also in for some kind of alterations to deal with that. Not sure what to do there, since it is a different thing altogether...but it's also like 10x faster or something, so it seems the proper way to go once released and stable. I see you pushed another commit. Is this tested and ready? |
Can definitely help with that when Pathom 3 is released.
I force-pushed an |
|
1.0.5 released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: Opens up new possibilities for custom auth plugins into RAD.
defresolver's::pc/transformhas been used to build an auth framework by other fulcro users. However, RAD's attributes bypassdefresolverand instead builds the resolver map manually.This PR adds the ability to specify a
::pc/transformin an attribute.If we want to merge this PR I would also like to:
attributes-options/pc-transformto RAD to clean this up.attribute-resolverThe
deps.ednchange just bumps dev-local to a more recent version (needed for testing, but I can move to another PR if preferred).