Add script to get usernames of course participants #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to add some documentation and a Makefile entry before merging. |
olehermanse
reviewed
May 13, 2017
src/get_usernames.py
Outdated
| argparser = argparse.ArgumentParser(description='Get usernames of students taking courses this semester') | ||
| argparser.add_argument('--username', '-u', help='Username for login', type=str) | ||
| argparser.add_argument('--password', '-p', help='Password for login', type=str) | ||
| argparser.add_argument('--semester', '-s', help='Semester to read data for', type=str) |
There was a problem hiding this comment.
Misleading. You can only get usernames for current semester, so this option only decides where to read/write in local data.
Semester to save data to
or similar.
|
@evestera Ready for review? |
|
@olehermanse Sure. Should be good to go. |
olehermanse
reviewed
May 16, 2017
olehermanse
approved these changes
May 16, 2017
| argparser.add_argument('--username', '-u', help='Username for login', type=str) | ||
| argparser.add_argument('--password', '-p', help='Password for login', type=str) | ||
| argparser.add_argument('--prev', help='Read data for the previous semester', action='store_true') | ||
| args = argparser.parse_args() |
There was a problem hiding this comment.
Would be useful to have an optional argument --filename or --input if you want to specify a different course list than spring.json or fall.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20
Needed for #21