Added CHC algorithm to Xsts #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately, horn solvers tend not to support custom datatypes and sorts, so I replaced every enumType with an int. |
leventeBajczi
added
the
Ready to test
mondokm
approved these changes
Aug 5, 2024
|
|
Benchexec test report for a selection of SV-Benchmarks (correct / incorrect / all):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Horn solving backend for Xstss.
Right now we don't support proof/CeX transformation, but that should be trivial, if it turns out this feature is useful.
I've added some tests, and it seems like there are no mistakes on the simple examples, but a more thorough testing would definitely be necessary.
Also, if it turns out this is useful, we could also think about useful ways of representing correctness proofs, because the horn solvers give us invariants for both the "env" and "trans" steps.