Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue Unit returning functions yield warning #936 #940

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Fixing issue Unit returning functions yield warning #936 #940

merged 4 commits into from
Sep 13, 2024

Conversation

MatthijsPrent
Copy link
Contributor

PR to fix issue #936

@nojaf
Copy link
Collaborator

nojaf commented Sep 13, 2024

Hello, thank you for this contribution.
Please run dotnet fantomas build.fsx src tests docs to format your changes.

nojaf
nojaf approved these changes Sep 13, 2024
View reviewed changes
Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do you want a release for this? Best I can do there is another alpha.

@MatthijsPrent
Copy link
Contributor Author

Thank you! For us a new release for this is not urgent. If another (alpha/beta) release will appear within +-3 months that is fine with me.

@nojaf nojaf merged commit b7c8f86 into fsprojects:main Sep 13, 2024
3 checks passed
@nojaf
Copy link
Collaborator

nojaf commented Sep 13, 2024

Gotcha, I would expect that to happen in that time frame. Poke me if not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthijsPrent @nojaf