Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FSharp.Core and FSharp.Compiler.Service dependencies #935

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

Thorium
Copy link
Member

@Thorium Thorium commented Aug 6, 2024

Temporary fix #934 to get the system to work with latest stable FSharp.Core until further decisions are considered.

@nojaf
Copy link
Collaborator

nojaf commented Aug 6, 2024

I'm ok with bumping this, please add a new beta entry in https://github.com/fsprojects/FSharp.Formatting/blob/main/RELEASE_NOTES.md

Copy link
Collaborator

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nojaf nojaf merged commit 31e0a51 into fsprojects:main Aug 6, 2024
3 checks passed
@nojaf
Copy link
Collaborator

nojaf commented Aug 6, 2024

Publish to NuGet didn't work, API key expired.

@dsyme can you help us with this?

image

@dsyme
Copy link
Contributor

dsyme commented Aug 15, 2024

@nojaf Just getting back from hols.

Yes it's that time of year :)

image

Note @sergey-tihon is also admin on the fsprojects Nuget.org org and can help with publish keys if I'm offline. (I don't think there's a way to derogate creation of particular project keys to particular project admins, short of having many Nuget.org organizations)

@dsyme
Copy link
Contributor

dsyme commented Aug 15, 2024

@nojaf Key updated

@nojaf
Copy link
Collaborator

nojaf commented Aug 16, 2024

Thanks Don, https://www.nuget.org/packages/FSharp.Formatting/21.0.0-beta-003 released @Thorium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax FSharp.Compiler.Service dependency version
3 participants