Clean up processes when the websocket exits

freman · May 19, 2016 · a644c10 · a644c10
1 parent f72bb67
commit a644c10
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/main.go b/main.go
@@ -46,10 +46,14 @@ func handleWebsocket(w http.ResponseWriter, r *http.Request) {
 		conn.WriteMessage(websocket.TextMessage, []byte(err.Error()))
 		return
 	}
-	defer tty.Close()
+	defer func() {
+		cmd.Process.Kill()
+		cmd.Process.Wait()
+		tty.Close()
+		conn.Close()
+	}()
 
 	go func() {
-		defer conn.Close()
 		for {
 			buf := make([]byte, 1024)
 			read, err := tty.Read(buf)
@@ -66,7 +70,6 @@ func handleWebsocket(w http.ResponseWriter, r *http.Request) {
 		messageType, reader, err := conn.NextReader()
 		if err != nil {
 			l.WithError(err).Error("Unable to grab next reader")
-			conn.WriteMessage(websocket.TextMessage, []byte(err.Error()))
 			return
 		}