-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor oauth2 Experiment module Implementation #191
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freizl
commented
Jun 14, 2023
freizl
force-pushed
the
refactor/oauth2-experiment
branch
from
June 27, 2023 04:48
287fbe0
to
eda7898
Compare
Closed
Hi @ocramz, since you had some experience at using the Experiment module, would you like take a look at this refactor and add any feedback you may have? Thanks in advance. |
- move most common to cabal file
freizl
changed the title
Refactor/oauth2 experiment
Refactor oauth2 Experiment module Implementation
Jun 27, 2023
This was referenced Jul 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove data type
GrantTypeFlow
, rather make concret type for each grant type.See
hoauth2/src/Network/OAuth2/Experiment/GrantType/
folder.Split type class for each flow into its own file and simplify the instance implementation a little bit.
See
hoauth2/src/Network/OAuth2/Experiment/Flows
folderGrantType
Application into flow request bodyConduitXXXRequest
stitch them together.Separate
IDP
fromApplication
.IdpApplication
is common data type instead of data family, which stichesIDP
and grant typeApplication
s.Notes
The impact to user who are using
hoauth2-provider
package seems minimal.See this diff for reference. (Changes to
hoauth2-providers-tutorial/src/HOAuth2ProvidersTutorial.hs
file)Further work
hoauth2-demo
cache enhancementIs there way to init all different Apps (AuthCode, ResourceOwnerPassword, ClientCreditials) into one cache?