Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XCMP Remark Test and Update Build Workflow #828

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Oct 18, 2024

PR Type

tests, enhancement


Description

  • Added a new test xcmp_remark_para_b to verify the XCMP remark functionality between parachains.
  • Updated the GitHub Actions build workflow to use the --locked flag during testing, ensuring locked dependencies.
  • Modified the metadata15.golden file to reflect a change in the metadata value.

Changes walkthrough 📝

Relevant files
Tests
laosish_xcm.rs
Add XCMP remark test for parachains                                           

xcm-simulator/src/tests/laosish_xcm.rs

  • Added a new test xcmp_remark_para_b to verify XCMP remark
    functionality.
  • The test sends a remark from one parachain to another and checks for
    the event.
  • +28/-0   
    Configuration changes
    build.yml
    Update build workflow to use locked dependencies                 

    .github/workflows/build.yml

    • Modified the test command to include the --locked flag.
    +1/-1     
    Miscellaneous
    metadata15.golden
    Update metadata golden file                                                           

    runtime/laos/src/tests/metadata15.golden

    • Updated a value in the metadata file from 244 to 245.
    +1/-1     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title add xcmp test Add XCMP Remark Test for Parachains Oct 18, 2024
    Copy link

    PR Description updated to latest commit (149c474)

    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title Add XCMP Remark Test for Parachains Add XCMP Remark Test and Update Build Workflow Oct 18, 2024
    Copy link

    PR Description updated to latest commit (5b8521b)

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant