Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Laosish XCM with asset support and comprehensive tests #807

Closed
wants to merge 90 commits into from

Conversation

asiniscalchi
Copy link
Member

@asiniscalchi asiniscalchi commented Oct 7, 2024

PR Type

Enhancement, Tests


Description

  • Updated XCM configuration for Laosish to use NetworkId::Kusama and adjusted UniversalLocation.
  • Refactored parachain setup by introducing constants for parachain IDs and updating configurations.
  • Enhanced parachain with support for foreign and trust-backed assets, including new types and configurations.
  • Added comprehensive tests for Laosish XCM operations, including DMP, UMP, asset creation, and balance transfers.
  • Updated project dependencies to include assets-common and pallet-assets.

Changes walkthrough 📝

Relevant files
Configuration changes
xcm_config.rs
Update XCM configuration for Laosish with new network settings

xcm-simulator/src/laosish/configs/xcm_config.rs

  • Changed RelayNetwork to NetworkId::Kusama.
  • Updated UniversalLocation to include GlobalConsensus.
  • +5/-2     
    Enhancement
    lib.rs
    Refactor parachain setup and account initialization           

    xcm-simulator/src/lib.rs

  • Introduced constants for parachain IDs.
  • Updated test parachain configurations to use new constants.
  • Added sibling account ID function.
  • Modified balance initialization to include sibling accounts.
  • +25/-10 
    parachain.rs
    Enhance parachain with foreign and trust-backed asset support

    xcm-simulator/src/parachain.rs

  • Added new types and configurations for foreign and trust-backed
    assets.
  • Implemented ForeignCreatorsUnique for asset creation.
  • Integrated ParachainInfo into the runtime.
  • +83/-6   
    Tests
    laosish_xcm.rs
    Add Laosish XCM tests for DMP, UMP, and asset operations 

    xcm-simulator/src/tests/laosish_xcm.rs

  • Added tests for DMP and UMP scenarios in Laosish.
  • Implemented tests for asset creation and balance transfers.
  • +100/-0 
    mod.rs
    Expand test coverage for XCM asset operations                       

    xcm-simulator/src/tests/mod.rs

  • Added new test functions for asset creation and transfers.
  • Enhanced existing tests with additional assertions.
  • +195/-2 
    Dependencies
    Cargo.toml
    Update dependencies to include assets-common                         

    Cargo.toml

    • Added assets-common dependency.
    +1/-0     
    Cargo.toml
    Add pallet-assets and assets-common to project dependencies

    xcm-simulator/Cargo.toml

  • Added pallet-assets and assets-common to dependencies.
  • Updated features to include new dependencies.
  • +10/-3   

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Base automatically changed from feature/integration-xcm-simulator to main October 8, 2024 14:23
    @asiniscalchi
    Copy link
    Member Author

    /describe

    @github-actions github-actions bot changed the title Feature/add laosish xcm tests Enhance Laosish XCM with asset support and comprehensive tests Oct 9, 2024
    Copy link

    github-actions bot commented Oct 9, 2024

    PR Description updated to latest commit (2aa6faf)

    @luispdm
    Copy link
    Contributor

    luispdm commented Oct 16, 2024

    Superseded by #813

    @luispdm luispdm closed this Oct 16, 2024
    @luispdm luispdm deleted the feature/add_laosish_xcm_tests branch October 16, 2024 13:35
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants