-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply SBP review comments #166
Conversation
/review |
PR Analysis
PR Feedback
How to use
|
/// | ||
/// Max PoV size is set to `5Mb` as all Cumulus-based parachains do. | ||
pub const MAXIMUM_BLOCK_WEIGHT: Weight = | ||
Weight::from_parts(WEIGHT_REF_TIME_PER_SECOND.saturating_mul(2), 5 * 1024 * 1024); | ||
Weight::from_parts(WEIGHT_REF_TIME_PER_SECOND.saturating_div(2), 5 * 1024 * 1024); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BlockGasLimit
computation depends on this constant, so by changing this we also address the comment about gas limit (reducing it from 60M to 15M).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub BlockGasLimit: U256 = U256::from(NORMAL_DISPATCH_RATIO * MAXIMUM_BLOCK_WEIGHT.ref_time() / WEIGHT_PER_GAS);
/improve better name for the test |
/ask what about a better name for the test ? |
[features] | ||
default = [] | ||
default = [ | ||
"txpool" | ||
] | ||
txpool = ["fc-rpc/txpool"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Consider adding a description for the "txpool" feature for better understanding of its purpose.
[features] | |
default = [] | |
default = [ | |
"txpool" | |
] | |
txpool = ["fc-rpc/txpool"] | |
[features] | |
# Enables transaction pool functionality | |
default = [ | |
"txpool" | |
] | |
txpool = ["fc-rpc/txpool"] |
Question: what about a better name for the test ? Answer: For instance, this test could be renamed to Remember, a good test name should quickly and accurately describe what the test does. It can be a bit longer if necessary - clarity is the key. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test to check txpool is working missing
As a LAOS dev, I want to make sure that the review provided by the SBP is duly taken care of, so my code is better
ACCEPTANCE:
we apply the changes we deem necessary from the provided review
The review test:
Still relevant: