-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing Asset Evolution Feature in Laos #125
Conversation
…verseio/laos into feature/move_evo_logic_into_caladan
…verseio/laos into feature/evolve_assets
/review |
PR Analysis
PR Feedback
How to use
|
/describe |
ownership-chain/precompile/laos-evolution/contracts/LaosEvolution.sol
Outdated
Show resolved
Hide resolved
/review -i |
Incremental PR Review
PR Analysis
PR Feedback
How to use
|
PR Type:
Enhancement
PR Description:
This PR introduces the asset evolution feature in the Laos project. The main changes include the addition of the 'evolve' function in the LaosEvolution trait, which allows for updating the token URI of an existing token. The PR also includes updates to the precompile and pallet tests to ensure the correct functionality of the new feature. Additionally, the LaosEvolution.sol contract has been updated to include the 'evolveWithExternalUri' function and the corresponding 'MetadataUpdate' event.
PR Main Files Walkthrough:
files:
ownership-chain/pallets/laos-evolution/src/traits.rs
: Added the "evolve_with_external_uri" function to the LaosEvolution trait.ownership-chain/pallets/laos-evolution/src/lib.rs
: Implemented the "evolve_with_external_uri" function in the LaosEvolution trait for the Pallet. Also, added the "EvolvedWithExternalTokenURI" event and the "AssetDoesNotExist" error.ownership-chain/pallets/laos-evolution/src/tests.rs
: Added tests for the "evolve_with_external_uri" function.ownership-chain/precompile/laos-evolution/src/lib.rs
: Added the "Evolve" action and implemented its execution in the "execute" function.ownership-chain/precompile/laos-evolution/src/tests.rs
: Added tests for the "Evolve" action.ownership-chain/precompile/laos-evolution/contracts/LaosEvolution.sol
: Added the "evolveWithExternalUri" function and the "MetadataUpdate" event.