Update Evolving Assets Logic to Use Contract Address #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions_use_contract_address
…ctions_use_contract_address
…:freeverseio/laos into feature/collections_use_contract_address
…:freeverseio/laos into feature/evolving_assets_logic_use_contract_address
…ctions_use_contract_address
…:freeverseio/laos into feature/evolving_assets_logic_use_contract_address
|
/describe |
github-actions
bot
changed the title
magecnion
changed the title
ghost
assigned 
Co-authored-by: dastan <[email protected]>
ghost
previously approved these changes
Nov 15, 2023
asiniscalchi
approved these changes
Nov 15, 2023
magecnion
deleted the
feature/evolving_assets_logic_use_contract_address
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type:
Enhancement
PR Description:
This PR includes several changes to the evolving assets logic, primarily shifting to use contract addresses. Key changes include:
ownership-chain/precompile/laos-evolution/src/tests.rsto reflect the new logic.ownership-chain/precompile/laos-evolution/src/lib.rsto match the new contract interface.ownership-chain/e2e-tests/tests/test-create-collection.tsandownership-chain/e2e-tests/tests/test-evolution.tsto use the new logic.createCollectionutility function inownership-chain/e2e-tests/tests/util.tsfor creating a new collection in the e2e tests.ownership-chain/precompile/laos-evolution/contracts/LaosEvolution.solto match the new interface.PR Main Files Walkthrough:
files:
ownership-chain/precompile/laos-evolution/src/tests.rs: Refactored the tests to use the new logic of using contract addresses instead of collection IDs. This includes modifying the input parameters and expected results of several tests.ownership-chain/precompile/laos-evolution/src/lib.rs: Updated the function selectors to match the new contract interface. Also, modified the logic in several functions to use contract addresses instead of collection IDs.ownership-chain/e2e-tests/tests/test-create-collection.ts: Refactored the tests to use the newcreateCollectionutility function, which creates a new collection using the new logic.ownership-chain/e2e-tests/tests/util.ts: Added acreateCollectionutility function for creating a new collection in the e2e tests.ownership-chain/precompile/laos-evolution/contracts/LaosEvolution.sol: Updated the LaosEvolution contract to match the new interface that uses contract addresses instead of collection IDs.