-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Evolving Assets Logic to Use Contract Address #173
Merged
magecnion
merged 44 commits into
main
from
feature/evolving_assets_logic_use_contract_address
Nov 15, 2023
Merged
Update Evolving Assets Logic to Use Contract Address #173
magecnion
merged 44 commits into
main
from
feature/evolving_assets_logic_use_contract_address
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctions_use_contract_address
…ctions_use_contract_address
…:freeverseio/laos into feature/collections_use_contract_address
…:freeverseio/laos into feature/evolving_assets_logic_use_contract_address
…ctions_use_contract_address
…:freeverseio/laos into feature/evolving_assets_logic_use_contract_address
/describe |
github-actions
bot
changed the title
Feature/evolving assets logic use contract address
Refactor Evolving Assets Logic to Use Contract Address
Nov 14, 2023
magecnion
changed the title
Refactor Evolving Assets Logic to Use Contract Address
Update Evolving Assets Logic to Use Contract Address
Nov 14, 2023
ghost
assigned magecnion
Nov 15, 2023
ghost
previously approved these changes
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Co-authored-by: dastan <[email protected]>
ghost
previously approved these changes
Nov 15, 2023
asiniscalchi
approved these changes
Nov 15, 2023
magecnion
deleted the
feature/evolving_assets_logic_use_contract_address
branch
November 15, 2023 11:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type:
Enhancement
PR Description:
This PR includes several changes to the evolving assets logic, primarily shifting to use contract addresses. Key changes include:
ownership-chain/precompile/laos-evolution/src/tests.rs
to reflect the new logic.ownership-chain/precompile/laos-evolution/src/lib.rs
to match the new contract interface.ownership-chain/e2e-tests/tests/test-create-collection.ts
andownership-chain/e2e-tests/tests/test-evolution.ts
to use the new logic.createCollection
utility function inownership-chain/e2e-tests/tests/util.ts
for creating a new collection in the e2e tests.ownership-chain/precompile/laos-evolution/contracts/LaosEvolution.sol
to match the new interface.PR Main Files Walkthrough:
files:
ownership-chain/precompile/laos-evolution/src/tests.rs
: Refactored the tests to use the new logic of using contract addresses instead of collection IDs. This includes modifying the input parameters and expected results of several tests.ownership-chain/precompile/laos-evolution/src/lib.rs
: Updated the function selectors to match the new contract interface. Also, modified the logic in several functions to use contract addresses instead of collection IDs.ownership-chain/e2e-tests/tests/test-create-collection.ts
: Refactored the tests to use the newcreateCollection
utility function, which creates a new collection using the new logic.ownership-chain/e2e-tests/tests/util.ts
: Added acreateCollection
utility function for creating a new collection in the e2e tests.ownership-chain/precompile/laos-evolution/contracts/LaosEvolution.sol
: Updated the LaosEvolution contract to match the new interface that uses contract addresses instead of collection IDs.