This repository has been archived by the owner on Oct 11, 2023. It is now read-only.
updating to the last substrate-template-node #52
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magecnion
reviewed
Aug 24, 2023
| @@ -292,7 +290,7 @@ construct_runtime!( | |||
| ); | |||
|
|
|||
| /// The address format for describing accounts. | |||
| pub type Address = AccountId; | |||
| pub type Address = sp_runtime::MultiAddress<AccountId, ()>; | |||
There was a problem hiding this comment.
Is it possible that there could be compatibility issues with the current running node? I assume the answer is 'no,' given that we don't have any storage yet, but I want to confirm just to be sure
There was a problem hiding this comment.
Good point!
The runtime that I'm tweaking is not installed in the Evochain. The integration of the Ethereum signature was more of a wannabe feature that was never deployed.
So, to clarify, the answer to your concern is indeed "Yes." However, this Pull Request (PR) addresses and removes the problem, ensuring that the system's integrity is maintained.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the evochain node with the code form the latest substrate-template-node and remove all the code about ethereum signature. As the ethereum signature is creating noise with current development and it's a feature we won't now.