Fix tcp-overflow test issue in TPORT. #109
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andywolk
requested changes
Feb 11, 2022
| @@ -2240,11 +2244,11 @@ int test_address_selection(struct context *ctx) | |||
| TEST_OC_ADDRESS(a, "2001:1508:1003::21a:a0ff:fe71:813", ip6); | |||
| TEST_VOID(soa_terminate(a, NULL)); | |||
|
|
|||
| /* SOATAG_AF(SOA_AF_IP4_IP6), o= mentions IP6 => select IP4 */ | |||
| /* SOATAG_AF(SOA_AF_IP4_IP6) and SOATAG_USER_O_LINE() tag remove from so, o= mentions IP6 => select IP6 */ | |||
There was a problem hiding this comment.
We do not have SOATAG_USER_O_LINE() tag in our codebase. But we have it's functionality enabled by default.
…number in sdp with changing test data.
…number in sdp with changing test data.
…VIRONMENT because AM_TESTS_ENVIRONMENT have not predefined value.
andywolk
force-pushed
the
make_check_change
branch
from
b5d93de
to
a4cdc25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.