Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(toolbar): Adds custom badge for Safari #380

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

ERosendo
Copy link
Contributor

@ERosendo ERosendo commented Jul 13, 2024

This PR addresses a few issues related to the badge introduced in #379, specifically for Safari.

While running the QA steps, I found the following issues:

This PR introduces the following changes:

  • Adds logic to identify the Safari engine and uses an exclamation mark as a substitute for the bell emoji. Here's a screenshot of how it looks:

image

  • Implements a new event-based approach to remove the badge after the popup closes. This method sends a message to the background script upon popup closure, bypassing the port-based mechanism used for Chrome and Firefox. Here's a GIF showing the badge is properly removed in Safari

Screen Recording 2024-07-12 at 11 49 18 PM

@ERosendo ERosendo force-pushed the feat-add-different-badge-for-safari branch from 79ad2be to 0126451 Compare July 13, 2024 03:54
@ERosendo ERosendo marked this pull request as ready for review July 13, 2024 03:58
@ERosendo ERosendo requested a review from mlissner July 13, 2024 04:03
src/toolbar_button.js Outdated Show resolved Hide resolved
@mlissner mlissner enabled auto-merge July 16, 2024 15:08
@mlissner mlissner merged commit 3caebcc into main Jul 16, 2024
8 checks passed
@mlissner mlissner deleted the feat-add-different-badge-for-safari branch July 16, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants