Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(text-extract): Add fix and test for recap-> op #193

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

flooie
Copy link
Collaborator

@flooie flooie commented Jun 14, 2024

Strip margin fails when maps/addendums are horizontal.

Add fix and tests for these documents

flooie and others added 2 commits June 14, 2024 14:45
Add fix for extract where addendums are turned horizontally
Maps etc these things caused strip margin to break.
Copy link

sentry-io bot commented Jun 14, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: doctor/lib/text_extraction.py

Function Unhandled Issue
get_page_text ValueError: Bounding box (0, 93.17647058823529, 792, 931.7647058823529) is not fully within parent page bound... ...
Event Count: 3

Did you find this useful? React with a 👍 or 👎

@flooie flooie merged commit d959044 into main Jun 14, 2024
10 checks passed
@flooie flooie deleted the doctor-text-extract-fix branch June 14, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant