Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved logging when plugins are cancelled for taking too long #323

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

Improved logging when plugins are cancelled for taking too long #323

wants to merge 18 commits into from

Commits on Mar 12, 2024

  1. Improved logging when plugins are cancelled for taking too long 

    Fixes: freeipa#322

Signed-off-by: Sam Morris <[email protected]>
    @yrro
    yrro committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    001e8d9 View commit details
    Browse the repository at this point in the history

  2. appease flake8

    @yrro
    yrro committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    47473e0 View commit details
    Browse the repository at this point in the history

  3. use new way to get utcnow

    @yrro
    yrro committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    e451258 View commit details
    Browse the repository at this point in the history

  4. fix logging exceptions raised by plugins

    @yrro
    yrro committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    5f54da6 View commit details
    Browse the repository at this point in the history

  5. fixup

    @yrro
    yrro committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    d6f6f20 View commit details
    Browse the repository at this point in the history

  6. Fix Rest expected behaviour WRT number of exceptions raised for each 

    plugin behaviour
    @yrro
    yrro committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    c55e556 View commit details
    Browse the repository at this point in the history

  7. appease flake8

    @yrro
    yrro committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    e82e074 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Use a dedicated key so that we can disambiguate failures caused by th… 

    …e timeout mechanism itself from failures caused by healthcheck plugins catching the TimeoutException and returning its own failures
    @yrro
    yrro committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    5265f8c View commit details
    Browse the repository at this point in the history

  2. simplify

    @yrro
    yrro committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    72f3281 View commit details
    Browse the repository at this point in the history

  3. should a healthcheck plugin timing out be critical?

    @yrro
    yrro committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    63386e7 View commit details
    Browse the repository at this point in the history

  4. typo

    @yrro
    yrro committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    ab79e14 View commit details
    Browse the repository at this point in the history

  5. provide a traceback to our timeout errors

    @yrro
    yrro committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    35a813a View commit details
    Browse the repository at this point in the history

  6. Use constent terminology - call them 'checks'

    @yrro
    yrro committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    9eaab1f View commit details
    Browse the repository at this point in the history

  7. timeout errors are critical

    @yrro
    yrro committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    14294d0 View commit details
    Browse the repository at this point in the history

  8. Use -- markers --- with existing log entries that delimit output from… 

    … checks
    @yrro
    yrro committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    71f20f0 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2024

  1. actaully chain the inner exception

    @yrro
    yrro committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    176dc85 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. pyflake

    @yrro
    yrro committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    494d7a3 View commit details
    Browse the repository at this point in the history

  2. syntax

    @yrro
    yrro committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    350cf6b View commit details
    Browse the repository at this point in the history