Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch actions top bar element #2233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

rocodes
Copy link
Contributor

@rocodes rocodes commented Sep 17, 2024

Status

Ready for review but presumes #2230 which should be reviewed first, will rebase once that's merged

Description

Add Top Bar UI element nested inside main layout, which will hold "Delete Sources" toolbar button (and eventually, other toolbar buttons). UI-only changes towards, #2160

Test Plan

  • Visual review
  • CI

Checklist

If these changes modify code paths involving cryptography, the opening of files in VMs or network (via the RPC service) traffic, Qubes testing in the staging environment is required. For fine tuning of the graphical user interface, testing in any environment in Qubes is required. Please check as applicable:

  • I have tested these changes in the appropriate Qubes environment
  • I do not have an appropriate Qubes OS workstation set up (the reviewer will need to test these changes)
  • These changes should not need testing in Qubes

If these changes add or remove files other than client code, the AppArmor profile may need to be updated. Please check as applicable:

  • I have updated the AppArmor profile
  • No update to the AppArmor profile is required for these changes
  • I don't know and would appreciate guidance

If these changes modify the database schema, you should include a database migration. Please check as applicable:

  • I have written a migration and upgraded a test database based on main and confirmed that the migration is self-contained and applies cleanly
  • I have written a migration but have not upgraded a test database based on main and would like the reviewer to do so
  • I need help writing a database migration
  • No database schema changes are needed

@rocodes rocodes changed the title Add bulk actions top bar element Add batch actions top bar element Sep 17, 2024
@rocodes rocodes added this to the 0.14.0 milestone Sep 17, 2024
@rocodes rocodes force-pushed the add-bulk-actions-pane branch 2 times, most recently from 0236763 to f9640a6 Compare September 18, 2024 08:33
@cfm
Copy link
Member

cfm commented Oct 2, 2024

Rebased from main to kick the tires. Oddly, GitHub still shows a conflict with main, but we can resolve that in the course of finishing and testing this work.

@rocodes rocodes force-pushed the add-bulk-actions-pane branch 2 times, most recently from 1b0942d to 2ad8e91 Compare October 3, 2024 13:18
@rocodes rocodes marked this pull request as ready for review October 3, 2024 13:49
@rocodes rocodes requested a review from a team as a code owner October 3, 2024 13:49
MainView layout to QVBoxLayout and add inner horizontal container to
accommodate inner top bar.

Update strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready For Review
Development

Successfully merging this pull request may close these issues.

2 participants