Replace usages of list.insert(0, ...)
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python, inserting an item at the beginning of a list incurs an O(n) penalty, because Python lists behave more like arrays - https://docs.python.org/3/glossary.html#term-list - and are opti- mized for appends, which are O(1). Remaining usages: ``` $ rg '\.insert\(' --glob='*.py' doc/source/conf.py 21:sys.path.insert(0, os.path.abspath('.')) tests/conftest.py 262: cmd.insert(0, 'iocage') iocage_lib/ioc_start.py 1753: rules.insert(1, f'{final_line}{rdrs}') 1763: rules.insert(1, nat_rule) ``` were inspected and do not pose any trouble.
Pull Request Test Coverage Report for Build 10333795135Details
💛 - Coveralls |
|
Thank you. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In my pursuit of deepening knowledge about
FreeBSD jails, a lot of people and books point toiocageas the way to go, so I checked the project. While doing so, I noticed usages oflist.insert(0, ...), which is a Python footgun, because despite the name, Python lists are more like arrays with optimized appends, not prepends, so such call incurs an O(n) runtime penalty.I decided to grep the codebase for
.insert(method calls and fix them in this pull request.Remaining usages:
were inspected and do not pose any trouble.
Make sure to follow and check these boxes before submitting a PR! Thank you.