Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on six #13

Merged
merged 1 commit into from
Jul 14, 2024
Merged

Conversation

bravesirrobin81
Copy link
Contributor

I noticed that the Python 3.11 iocage-devel package has a missing dependency onsix. Given it's only used in one place, and for compatibility with Python 2 which is no longer supported, remove it.

Make sure to follow and check these boxes before submitting a PR! Thank you.

We no longer support Python 2, so remove the compatibility shim.
@coveralls
Copy link

coveralls commented Jun 29, 2024

Pull Request Test Coverage Report for Build 9724386434

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 7.795%

Changes Missing Coverage Covered Lines Changed/Added Lines %
iocage_lib/utils.py 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
iocage_lib/release.py 1 0.0%
Totals Coverage Status
Change from base Build 9566853401: -0.4%
Covered Lines: 798
Relevant Lines: 7755

💛 - Coveralls

@arrowd
Copy link

arrowd commented Jul 12, 2024

@dgeo The PR makes sense, may I merge it?

@dgeo
Copy link
Contributor

dgeo commented Jul 13, 2024

@arrowd of course you may, I can't check it now but feel free !

@arrowd arrowd merged commit 38d0416 into freebsd:master Jul 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants