The Ports Collection is now git-based

[motminh]

Pull requests are accepted at https://github.com/freebsd/freebsd-ports

[yurivict]

I don't think that this is an acceptable change.

Let's say I maintain the port x/y, and someone would submit a pull request.
How would I be notified about this PR and other PRs for my ports?
Is there a mechanism of notification?
Is there a mechanism for port committers to merge/reject GitHub PRs?

[bsdimp]

Right now the volume is low enough it can be done manually. But we make no qos on these requests, and don't count it toward timeouts. For the moment, you'd find out by someone looking at things on github. And of course there's a mechanism for rejecting a change: comment on the pull request now and close it if it's bad. Just like you would in Bugzilla...

If you want, please automation join my github working group. That's the right answer long term. It hopes to get automation like this into github.

[bsdimp]

I'd make sure that people know of the still experimental nature of prs.

[concussious]

Suggested change

	FreeBSD does accept pull requests.
	Please see the [Porter's Handbook](https://docs.freebsd.org/en/books/porters-handbook/) section on [Submitting patches](https://docs.freebsd.org/en/books/porters-handbook/quick-porting/#porting-submitting).
	# FreeBSD Ports Collection Contribution Guidelines
	Contributions may be submitted to the FreeBSD Ports Collection via one of three methods:
	- Attachments to [Bugzilla tickets](https://bugs.freebsd.org) are preferred, as this notifies existing maintainers.
	- Code reviews on [Phabricator](https://reviews.freebsd.org/differential) are accepted by some maintainers.
	- GitHub Pull Requests are an experimental feature and should expect additional delay.
	To learn more about contributing to the FreeBSD Ports Collection, please see the [Porter's Handbook](https://docs.freebsd.org/en/books/porters-handbook/) section on [Submitting patches](https://docs.freebsd.org/en/books/porters-handbook/quick-porting/#porting-submitting).

[concussious]

TIL more about this issue and edited my suggestion above. One thumbs up emoji appeared before today's edit and does not reflect the new suggestion.

[diizzyy]

I'd argue that we shouldn't accept PRs at all, no one looks at this regulary (that commits) and given that it's not covered by Porters Handbook we're just going to suggest people to submit it bugzilla instead anyway.

[concussious]

This is a feature that we have, PR is just updating the doc to reflect that.

All it takes is someone to start, but beloved ports team is currently doing an unprecedented amount of work per person according to the presentation at nycbug. If I'm understanding policy correctly it's a "when" not an "if", and the language I suggested reflects that.