Fix #104: keychain.h now contains a correct define for keychain version. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keychain version.
akallabeth
force-pushed
the
fix_version_define
branch
from
689e28a
to
cd45d25
Compare
ogoffart
suggested changes
Jul 11, 2018
There was a problem hiding this comment.
I'm not a fan of having qtkeychain.h being auto-generated. This means working with the project would be harder as jumping to symbol and stuff would jump to that generated file and not the original.
Also, the CMakeLists.txt contains
set(QTKEYCHAIN_VERSION 0.8.90)
Which, appart from being also outdated, is also not a valid C++ token, so that means you cannot use it to detect the version at compile time.
Maybe it would be best to add a comment saying "keep in sync with that other file" would be enough, so the one increasing the version would not forget to update the two files. It's not like the version is increased that often anyways.
|
How about moving the version number to a separate generated header, included by keychain.h? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keychain.his now a configure file where the variable gets replaced with a proper value.