Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exec' returning number of affected rows #52

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

yaitskov
Copy link

No description provided.

@yaitskov
Copy link
Author

@psibi @qrilka, please review PR.

@yaitskov yaitskov changed the title row-count exec' returns number of affected rows Add exec' returning number of affected rows Nov 21, 2022
@psibi
Copy link
Member

psibi commented Dec 1, 2022

@yaitskov Sorry about the late reply. Looks good to me from a quick look. Can you add a test for the introduced function ?

Also, probably can it be renamed to something else. Probably execRows or execAffectedRows ?

@yaitskov
Copy link
Author

yaitskov commented Dec 6, 2022

Thanks for review, @psibi

arOnCreate <- Internal.execAffectedRows
c
"CREATE TABLE test (int integer, text text, bool bit, nt ntext, fl float)"
_ <- Internal.execAffectedRows
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this return 3 too ?

Copy link
Member

@psibi psibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants