feat: optimize local calls #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fp-crypto
force-pushed
the
fp-optimize-internal-calls
branch
from
0134c07
to
e24cd92
Compare
poolpitako
approved these changes
Aug 28, 2023
| @@ -61,14 +63,28 @@ abstract contract VM { | |||
| ) | |||
| ); | |||
| } else if (flags & FLAG_CT_MASK == FLAG_CT_CALL) { | |||
There was a problem hiding this comment.
shouldn't STATICCALL and VALUECALL also have the same behavior?
pata-eth
reviewed
Sep 12, 2023
| @@ -29,6 +29,8 @@ abstract contract VM { | |||
| self = address(this); | |||
| } | |||
|
|
|||
| function dispatch(bytes memory inputs) internal virtual returns (bool success, bytes memory ret) {} | |||
There was a problem hiding this comment.
were these changes to the VM incorporated into ape-roll?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.