-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cheatcodes
): access broadcast artifacts
#9107
base: master
Are you sure you want to change the base?
Conversation
cheatcodes
): access broadcast artifacts
crates/cheatcodes/src/fs.rs
Outdated
} | ||
} | ||
|
||
struct BroadcastReader { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add some comments to struct and functions. Also, would it make sense to move the reader in a common crate so it could also be used from other places, wdyt? (like if we want to provide a cli for broadcast history)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would cause cyclic deps between common and script-seqeunce. I could move it to script-sequence? @grandizzy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, I see, I think should work. @klkvr wdyt, would script-sequence be a good place or not worth moving it?
Motivation
Builds upon #9098
Closes #4732 + Closes #9083
Solution