-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cast): add --timeout
option
#9044
Open
PanGan21
wants to merge
8
commits into
foundry-rs:master
Choose a base branch
from
PanGan21:cast-add-rpc-timeout-flag
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+17
−2
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2ae9e2f
feat: add timeout flag and override default rpc timeout value
PanGan21 2a4d68b
Merge branch 'master' into cast-add-rpc-timeout-flag
PanGan21 99d442e
fix clippy
PanGan21 1666ac4
fix: move timeout to rpc args
PanGan21 eced274
Merge branch 'master' into cast-add-rpc-timeout-flag
PanGan21 285ea8c
Merge branch 'master' into cast-add-rpc-timeout-flag
PanGan21 fd99ed3
Merge branch 'master' into cast-add-rpc-timeout-flag
PanGan21 1802127
Merge branch 'master' into cast-add-rpc-timeout-flag
PanGan21 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should add this to Config and RpcOpts, so that it's always available in get_provider across the codebase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @mattsse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this as first option in previous commit and it was conflicting with --timeout for other commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it would be possible but the flag should be named differently
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other commands should also use the config's and RpcOpts timeout then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They map thought to a different Config property. (example
Config::transaction_timeout
)Here is an example of failing tests when timeout was in RpcOpts:
https://github.com/foundry-rs/foundry/actions/runs/11200334838/job/31133848891
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @DaniPopes just following up on this so we can complete the feature.
Do you believe we should rename the flags of the other commands to something else which will allow to add this timeout to RpcOpts? Their functionality seem different to me so it doesn't seem wise to use the same
RpcOpts::timeout
for everything.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I think so, a global timeout flag/config makes sense
cc @mattsse @klkvr for more opinions