fix: include traces field when running forge test -vvvv --json
#9034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n, includes tests
zerosnacks
requested review from
DaniPopes,
klkvr,
mattsse,
grandizzy and
yash-atreya
as code owners
DaniPopes
requested changes
Oct 4, 2024
Co-authored-by: DaniPopes <[email protected]>
Co-authored-by: DaniPopes <[email protected]>
DaniPopes
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes: #6922
Part of a larger meta-ticket: #8794
Solution
Enable and includes traces in JSON output when
forge testis ran with--jsonenabled (and verbosity >= 3)Includes Snapbox tests
Future improvements could include making
TraceWriterinrevm-inspectorsJSON compatible so we return decoded traces and well as #7813 once that is added.This should not impact the JUnit XML reports as that follows a strict schema already