Change SassC dependency to Dart Sass #790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not familiar with the dartsass libraries, but it looks like sass-embedded and sassc-embedded are actively maintained and the library chosen by dartsass-rails, while dartsass was last updated 2 years ago. |
|
You're quite right. I use dartsass-rails so I mistakenly assumed that they use dartsass. It seems sassc-embedded is the recommended option to go for. I'll adjust the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since SassC no longer supports the newer syntax used in foundation 6.8+, this pull request changes the dependency to Dart Sass.