Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code doesn't fix any bug or add new feature.
It minimize promise chaining in asynchronous functions.
Replaced .then with “async - await” wherever possible.
Please describe the changes in your pull request in few words here.
Changes
Before:
const fetchVersion = () => {
return getFossologyVersion()
.then((res) => {
setSessionStorage("fossologyVersion", res);
setVersion(res);
return res;
})
.catch(() => null);
};
After:
const fetchVersion = async () => {
try {
const res = await getFossologyVersion();
setSessionStorage("fossologyVersion", res);
setVersion(res);
return res;
} catch (error) {
return null;
}
};
Please consider using the closing keyword if the pull request is proposed to
fix an issue already created in the repository
closes #261
(https://help.github.com/articles/closing-issues-using-keywords/)