Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the Bottom Nav Sliding Direction Issue #2924

Closed
wants to merge 5 commits into from
Closed

Fixed the Bottom Nav Sliding Direction Issue #2924

wants to merge 5 commits into from

Conversation

satyajiit
Copy link

Fixed #2923

Changes: Added a global variable to MyApplication Class.
And applied transition based on logic/conditions to each of the three activities.
NavItem starts from zero to two.
Since we have three NavItems.
Added four new anim xml files and deleted the old two.

This PR also contains fix for #2894

GIF :
gif

@satyajiit
Fixed Image Delete Issue , TrashBin Issue and More
73b6212 
Clicking on Delete Icon on the Toolbar now deletes all the images.
Fixed issue when images of same name are added by changing the PrimaryKey from binPath to an auto_increment id.
Fixed an issue in which files are not deleted from ".nomedia" directory.
Also Updated some external library versions.
@satyajiit
Fixed Image Delete Issue , TrashBin Issue and More
85c9373 
Clicking on Delete Icon on the Toolbar now deletes all the images.
Fixed issue when images of same name are added by changing the PrimaryKey from binPath to an auto_increment id.
Fixed an issue in which files are not deleted from ".nomedia" directory.
Also Updated some external library versions.
@satyajiit
Fixed the Sliding Directions
03a8b0e 
Added a global variable to MyApplication Class.
And applied tranisition based on logic/condtions to each of the three activity.
NavItem starts from zero to two.
Since we have three NavItems.
@mariobehling
Copy link
Member

Thanks. Please resolve conflicts.

@satyajiit
Copy link
Author

Done . Sorry for that conflict 🙂

codedsun
codedsun suggested changes Nov 18, 2019
View reviewed changes
Copy link
Contributor

@codedsun codedsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed more than 2 issues in the same PR. Please only perform changes that are relevant to the issue. Also remove the irrelevant changes which are not to be done in a PR

@codedsun
Copy link
Contributor

Please review my comment, PR contains unnecessary code yet.

@satyajiit
Copy link
Author

@codedsun When building with SDK 29 ,
on Android 10 ,
it gives error on run.

 java.lang.RuntimeException: Unable to start activity ComponentInfo{org.fossasia.phimpme/org.fossasia.phimpme.gallery.activities.SplashScreen}: android.view.InflateException: Binary XML file line #17 in org.fossasia.phimpme:layout/abc_screen_simple: Binary XML file line #17 in org.fossasia.phimpme:layout/abc_screen_simple: Error inflating class androidx.appcompat.widget.FitWindowsLinearLayout
        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3374)

But compiling with SDK 28 resolves the issue.
Because of some outdated libraries.

No crash occurs when run with versions < android 10 .

@codedsun
Copy link
Contributor

@satyajiit Then what about the devices running on android 10?

@satyajiit
Copy link
Author

satyajiit commented Nov 18, 2019 •
edited
Loading

@codedsun I am testing the App on Android 10.
The exact issue with build.gradle changes :
compileSdkVersion 29
buildToolsVersion "29.0.2"
targetSdkVersion 29

Gradle build will succeed but if test the App on Android 10 ,
Just in the SplashScreen the app will crash.
I am using OnePlus7 .

But If i build the project with Sdk28 and buildTools 28 ,
All works fine.

@satyajiit
Copy link
Author

I am closing this PR ,
And making another with fix to only #2923 .
Thank You @codedsun

@satyajiit satyajiit closed this Nov 18, 2019
@satyajiit satyajiit deleted the devlopment2 branch November 18, 2019 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codedsun codedsun codedsun requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bottom menu bar "move in effect" not from expected direction
3 participants
@satyajiit @mariobehling @codedsun