Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chinese Translation #393

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

quanzhuo
Copy link

@quanzhuo quanzhuo commented Mar 4, 2022

Add Chinese translation in configuration

Signed-off-by: Quan Zhuo <[email protected]>
@gnikit
Copy link
Member

gnikit commented Mar 4, 2022

Hi @quanzhuo, nice contribution. I am in general in favour of adding support for languages other than English but we need to be careful how we do it, for a couple of reasons.

  1. It needs to be done to all the UI elements not just the package.json i.e. descriptions of settings
  2. We have no way of maintaining it, so it will inevitably end up being out of date whenever we change/add/remove settings. For example see the PR for version 3.0 Development version #293

To address the 1st point the implementation would have to look something like what the vscode-cpptools. For the 2nd point I actually have no idea how to address, any thoughts on that?

@quanzhuo
Copy link
Author

quanzhuo commented Mar 4, 2022

@gnikit Very considerate of you. I can't find a very convenient way to address the second point. Maybe you can set owner for each language. And only release new version after all the i18n work is done.

@gnikit
Copy link
Member

gnikit commented Mar 7, 2022

@gnikit Very considerate of you. I can't find a very convenient way to address the second point. Maybe you can set owner for each language. And only release new version after all the i18n work is done.

That is a bit of an issue since it will increase the development time quite substantially (currently, I am the only one actively maintaining the extension). I will see if this can be added to version 3.0. and if so I will tag you in that PR.

@quanzhuo
Copy link
Author

quanzhuo commented Mar 8, 2022

I will see if this can be added to version 3.0. and if so I will tag you in that PR.

If this PR is merged. And you add new settings afterwards. You can at me, I am glad to help translating it to Chinese.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants