Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update author picture in API documentation webpage #842

Merged
merged 2 commits into from
Jul 7, 2024

Conversation

jvdp1
Copy link
Member

@jvdp1 jvdp1 commented Jul 1, 2024

Fixes #838
Replacing the link to a valid does not solve the issue.
The same issue is also in fpm API website.

@jvdp1 jvdp1 requested review from perazz and a team July 2, 2024 11:48
Copy link
Contributor

@perazz perazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jvdp1. Do you think this may be a bug with FORD?

@jvdp1
Copy link
Member Author

jvdp1 commented Jul 2, 2024

I don't know. I just looked to other FORD-based websites and none of them use this feature.

@perazz
Copy link
Contributor

perazz commented Jul 3, 2024

@jvdp1 the Fortran website repository uses a slightly different path:

https://fortran-lang.org/en/_static/fortran-logo-256x256.png

That is a 256 pixel version however, I couldn't find a 512 one.

@jvdp1
Copy link
Member Author

jvdp1 commented Jul 3, 2024

@perazz I tested it but I got the same result. Is it working for you? If not, it seems to be a bug in Ford.

@perazz
Copy link
Contributor

perazz commented Jul 4, 2024

@jvdp1 I've tried to build it locally, and I do see the icon. It's slightly blurred. So, I'll let you decide: I think either replacing or removing the icon are both improvements!

@perazz perazz mentioned this pull request Jul 4, 2024
Co-authored-by: Jeremie Vandenplas <[email protected]>
@jvdp1
Copy link
Member Author

jvdp1 commented Jul 4, 2024

@jvdp1 I've tried to build it locally, and I do see the icon. It's slightly blurred. So, I'll let you decide: I think either replacing or removing the icon are both improvements!

Thank you. I merged your changes in my branch. This PR can be now merged IMO.

@perazz
Copy link
Contributor

perazz commented Jul 5, 2024

I agree: let's wait a bit longer and merge during the weekend.

@jvdp1 jvdp1 changed the title Remove author picture in API documentation webpage Update author picture in API documentation webpage Jul 7, 2024
@jvdp1
Copy link
Member Author

jvdp1 commented Jul 7, 2024

Thank you. I will merge it.

@jvdp1 jvdp1 merged commit e01b3a3 into fortran-lang:master Jul 7, 2024
17 checks passed
@jvdp1 jvdp1 deleted the fix_pic_ford branch July 7, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid author picture in API documentation web page
2 participants