Fix undefined use of <cstdint> types #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… are not defined on all platforms
jvdp1
approved these changes
Nov 19, 2023
There was a problem hiding this comment.
Thank you @harmenwierenga . LGTM. I'll merge it if all tests are successful.
|
Thank you! There are two failing checks, cmake can’t find ifort on Ubuntu-latest and there is some setup failure on MSYS. Could you have a look at those? |
|
@harmenwierenga Could you rebase your branch, please? It should then trigger the updated CI. |
|
Thanks for the message, I have synced the branch. Could you please approve the workflow? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not compile tests on windows, since SpookyV2Test.cpp uses types from the cstdint header (e.g., uint64_t) without including the header. The type aliases are already defined in SpookyV2.h, so I have used those type aliases instead.