Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constraint trigger impl #221

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

noeliaarcadiaconsulting

Implementation for support of CONTRAINT option in TRIGGERS:
-Modified PATTERN_CREATE_TRIGGER for CONSTRAINT option support for TRIGGER
-Modified CreateTriggerParser.java for CONSTRAINT support for TRIGGER with EventTimeQualification expected AFTER and optionaly { NOT DEFERRABLE | [ DEFERRABLE ] { INITIALLY IMMEDIATE | INITIALLY DEFERRED } }
-Modified PgTrigger.java for CONSTRAINT options support in sql statement for TRIGGER.

@chadfurman
Copy link
Collaborator

This builds on your other PR, yes?

I won't have time to pull this down and test it for a little while. Would love help with the review...

@noeliaarcadiaconsulting
Copy link
Author

The other PR (Oldrelation delete triggers) builds on this one. So, Oldrelation delete triggers PR contains all the changes made.
What do you need help with?

@chadfurman
Copy link
Collaborator

@noeliaarcadiaconsulting I need someone who isn't the PR author to review this PR and say it looks good.

I also think there might be a need for some tests. Not sure what the state of testing is in this repo

The PR generally looks good, so I'm just after some additional sign-off w.r.t. compilation and general code structure. Someone, preferrably, who knows Java and has read all the code in this PR

@jalissonmello
Copy link
Contributor

Hi,
Still need one more to help with tests ? I' am interested to put the changes on main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants