Fix for the duplicate work item creation #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jag-j
commented
Feb 18, 2021
| return await updateIssue(req, 'Error while creating work item. No valid build foundin GUS!'); | ||
| // If issue is a bug we check if it already exists and already has lowest priority | ||
| // If issue type is investigation or story, we simply check it exists | ||
| if (isRecordTypeBug && alreadyLowestPriority && recordIdTypeIsSame) { |
There was a problem hiding this comment.
This is the main fix. We don't look for priority anymore for investigation and story.
jag-j
commented
Feb 18, 2021
| } | ||
| } else { | ||
| const foundInBuild = await Builds.resolveBuild(config, milestone); |
There was a problem hiding this comment.
This is the old connectAPI code we don't use anymore. Removed them all.
jag-j
commented
Feb 18, 2021
| @@ -197,219 +245,224 @@ const reqWithGusTitlePrefix = { | |||
| }; | |||
|
|
|||
| describe('createGusItem action', () => { | |||
There was a problem hiding this comment.
Updated all the tests to check for the GUS API interaction rather than the old Connect API push. Added couple of pin-down tests for the bug I fixed.
jag-j
commented
Feb 18, 2021
| expect(sails.hooks['issues-hook'].queue.push).not.toHaveBeenCalled(); | ||
| expect(Gus.createWorkItemInGus).not.toHaveBeenCalled(); | ||
| }); | ||
| it('should not call createWorkItemInGus if bug already exists in GUS', async () => { |
There was a problem hiding this comment.
Added this and the test below for the fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes this issue that multiple users have reported - #97