Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed compile error (issue #45) #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

q-lukasz
Copy link

  • upgraded nan to >= 2.14.0
  • fixed a call in FontDescriptor.h

Possibly the code before my change worked for people with Node 12 but it simply does not compile for Node 13.

@manu-st
Copy link

manu-st commented Nov 7, 2020

Could we merge this PR and create a new version of font-manager that compiles with recent version of NodeJS? Thanks!

@manu-st manu-st mentioned this pull request Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants