-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -111,12 +111,12 @@ instance Typeable a => VarExp [Var a] where | |
|
||
class Accessor t where | ||
currentValue :: (OverflowType a, VarExp e) => e -> t a | ||
currentValue x = currentValue' x 0 | ||
currentValue' :: (OverflowType a, VarExp e) => e -> Int -> t a | ||
currentValue x = recentValue x 0 | ||
recentValue :: (OverflowType a, VarExp e) => e -> Int -> t a | ||
|
||
allValues :: (OverflowType a, VarExp e) => e -> t [a] | ||
allValues x = allValues' x 0 | ||
allValues' :: (OverflowType a, VarExp e) => e -> Int -> t [a] | ||
allValues x = recentValues x 0 | ||
recentValues :: (OverflowType a, VarExp e) => e -> Int -> t [a] | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
jvoigtlaender
Member
|
||
|
||
as :: Typeable a => t a -> t a | ||
as = id | ||
|
1 comment
on commit 71f6d82
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing the accessor names should also impact the Demo repo, since at least one example there used currentValue'
.
Is
recentValues
a good name? It seems like it skips the most recentn
values, and then returns the ones that occured before that. If that is the behavior, it seems more likeearlierValues
or maybe evenpastValuesBefore
rather thanrecentValues
would make sense.