Remove non-character NPCs #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #148
This change removes NPCs as a special concept that was used before NPC were reintroduced as regular Characters with NPC flag in 3.2.0. Existing NPCs were migrated to Character NPCs. This streamlines further development of Combat features since previously everything that touched combatants would have to be developed twice.
I already ran the migrations and I noticed, that links between Encounters and non-character NPCs were accidentally lost, so this may have removed NPCs from some old encounters (we are talking > 1 year old). I am sorry about that, but there is nothing I can do with it now.