Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Integrate OpenTelemetry #538

Open
wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Integrate OpenTelemetry #538

wants to merge 27 commits into from

Conversation

hamersaw
Copy link
Contributor

@hamersaw hamersaw commented Mar 7, 2023 •
edited
Loading

DO NOT MERGE waiting on PRs:
flyteorg/flytestdlib#146

TL;DR

This PR integrates opentelemetry into flytepropeller to facilitate observability into workflow evaluation performance from an orchestration level.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

flyteorg/flyte#3304

Follow-up issue

NA

@hamersaw
exporting HandleWorkflow and Streak spans
fb6ad82 
Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw
continuing to fill out spans and events
4af9329 
Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw
commented out imports
b5c549d 
Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw
using update span generator
ee1f781 
Signed-off-by: Dan Rammer <[email protected]>
@hamersaw
using latest NewSpan definition
28d620c 
Signed-off-by: Dan Rammer <[email protected]>
@hamersaw
instrumented datacatalog grpc calls
e9f7ce2 
Signed-off-by: Dan Rammer <[email protected]>
@hamersaw
Merge branch 'master' into feature/open-telemetry
c8689f4 
Signed-off-by: Dan Rammer <[email protected]>
@hamersaw
cleanup go.mod
771a7a5 
Signed-off-by: Dan Rammer <[email protected]>
@hamersaw
updating beginning timestamps
5c7e074 
Signed-off-by: Dan Rammer <[email protected]>
@hamersaw
Merge branch 'feature/open-telemetry' into feature/performance-observ…
d01dfc1 
…ability
@hamersaw
Merge branch 'feature/update-runtime-timestamps' into feature/perform…
9387d6a 
…ance-observability
@hamersaw
added script
845a8a3 
Signed-off-by: Dan Rammer <[email protected]>
@hamersaw
added support for reportedat on task events
6a924dc 
Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw
Merge branch 'master' into feature/performance-observability
f405b78 
Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw
removed runtime metrics code
ca63cc9 
Signed-off-by: Daniel Rammer <[email protected]>
@hamersaw hamersaw mentioned this pull request Mar 7, 2023
Closed
8 tasks
@codecov
Copy link

codecov bot commented Mar 9, 2023 •
edited
Loading

Codecov Report

Merging #538 (502c135) into master (230d405) will increase coverage by 0.45%.
The diff coverage is 77.41%.

❗ Current head 502c135 differs from pull request most recent head 6d78cec. Consider uploading reports for the commit 6d78cec to get more accurate results

@hamersaw hamersaw mentioned this pull request Mar 9, 2023
Draft
3 tasks
@hamersaw hamersaw marked this pull request as ready for review July 26, 2023 17:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 is a code owner

@EngHabu EngHabu Awaiting requested review from EngHabu EngHabu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hamersaw