Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Extract CatalogClient from flytepropeller to flytestdlib #509

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MorpheusXAUT
Copy link
Contributor

TL;DR

The CatalogClient implementation has been extracted from flytepropeller's source code and moved to flytestdlib as flyteadmin also needs access to the functionality.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

The whole latest implementation of the catalog package was moved from flytepropeller to flytestdlib since flyteadmin will need access to a client interacting with datacatalog for evicting cached executions.

The PR was created as a draft until the flyteidl, flyteplugins and flytestdlib PRs have been merged and respective versions have been published.

Tracking Issue

flyteorg/flyte#2867

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Dec 15, 2022

Codecov Report

Merging #509 (93eb7b4) into master (08bdbd0) will decrease coverage by 0.47%.
The diff coverage is 50.00%.

Nick Müller added 2 commits January 4, 2023 16:10
Adapted NewClient renaming for catalog client
Updated to latest unpublished version of flyteidl, flyteplugins and flytestdlib

Signed-off-by: Nick Müller <[email protected]>
@MorpheusXAUT
Copy link
Contributor Author

Rebased onto current master branch.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant