Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Commit

Permalink
Readd GroupVersionKind changes
Browse files Browse the repository at this point in the history
Signed-off-by: Andrew Dye <[email protected]>
  • Loading branch information
andrewwdye committed Sep 29, 2023
1 parent ca5e4e8 commit fe453eb
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 11 deletions.
9 changes: 4 additions & 5 deletions pkg/controller/nodes/task/k8s/event_watcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import (
eventsv1 "k8s.io/api/events/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/fields"
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apimachinery/pkg/runtime/schema"
"k8s.io/apimachinery/pkg/types"
"k8s.io/client-go/informers"
informerEventsv1 "k8s.io/client-go/informers/events/v1"
Expand Down Expand Up @@ -106,10 +106,9 @@ func (e *eventWatcher) List(objectNsName types.NamespacedName, createdAfter time
return result
}

func NewEventWatcher(ctx context.Context, obj runtime.Object, kubeClientset kubernetes.Interface) (EventWatcher, error) {
kind := obj.GetObjectKind().GroupVersionKind().Kind
func NewEventWatcher(ctx context.Context, gvk schema.GroupVersionKind, kubeClientset kubernetes.Interface) (EventWatcher, error) {
objectSelector := func(opts *metav1.ListOptions) {
opts.FieldSelector = fields.OneTermEqualSelector("regarding.kind", kind).String()
opts.FieldSelector = fields.OneTermEqualSelector("regarding.kind", gvk.Kind).String()
}
eventInformer := informers.NewSharedInformerFactoryWithOptions(
kubeClientset, 0, informers.WithTweakListOptions(objectSelector)).Events().V1().Events()
Expand All @@ -119,7 +118,7 @@ func NewEventWatcher(ctx context.Context, obj runtime.Object, kubeClientset kube
eventInformer.Informer().AddEventHandler(watcher)

go eventInformer.Informer().Run(ctx.Done())
logger.Debugf(ctx, "Started informer for [%s] events", kind)
logger.Debugf(ctx, "Started informer for [%s] events", gvk.Kind)

return watcher, nil
}
12 changes: 6 additions & 6 deletions pkg/controller/nodes/task/k8s/plugin_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -634,20 +634,20 @@ func NewPluginManager(ctx context.Context, iCtx pluginsCore.SetupContext, entry
return nil, err
}

gvk, err := getPluginGvk(entry.ResourceToWatch)
if err != nil {
return nil, err
}

var eventWatcher EventWatcher
if config.GetK8sPluginConfig().SendObjectEvents {
eventWatcher, err = NewEventWatcher(ctx, entry.ResourceToWatch, kubeClientset)
eventWatcher, err = NewEventWatcher(ctx, gvk, kubeClientset)
if err != nil {
return nil, err
}
}

// Construct the collector that will emit a gauge indicating current levels of the resource that this K8s plugin operates on
gvk, err := getPluginGvk(entry.ResourceToWatch)
if err != nil {
return nil, err
}

pluginInformer, err := getPluginSharedInformer(ctx, kubeClient, entry.ResourceToWatch)
if err != nil {
return nil, err
Expand Down

0 comments on commit fe453eb

Please sign in to comment.