Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Edit Project Description #5806

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

robert-ulbrich-mercedes-benz
Copy link
Contributor

Why are the changes needed?

This change allows to set the description of a Flyte project. It could hold the responsible team for a Flyte project including the contact data or some other information.

What changes were proposed in this pull request?

  • A new config map file was introduced including keys in the Helm chart were updated for the flyte-core Helm chart so they can hold a name and a description for the project
  • A new structure was introduced that holds the project information to be handed over to the database repository
  • For the flyte-binary and the single binary approach the structure of the Helm chart was changed

How was this patch tested?

  • The implementation was tested by running the regular set up process for the single binary approach
  • Also the regular flyteadmin migrate seed-projects was tested with the adapted flyte-single-binary-local.yaml config file

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

The program was tested solely for our own use cases, which might differ from yours

Robert Ulbrich [email protected], Mercedes-Benz Tech Innovation GmbH, legal info/Impressum

# Conflicts:
#	docker/sandbox-bundled/manifests/complete-agent.yaml
#	docker/sandbox-bundled/manifests/complete.yaml
#	docker/sandbox-bundled/manifests/dev.yaml
#	flyteadmin/pkg/manager/impl/testutils/mock_requests.go
#	flyteadmin/pkg/manager/impl/validation/execution_validator_test.go
#	flytepropeller/pkg/compiler/validators/bindings_test.go
# Conflicts:
#	charts/flyte-core/README.md
#	deployment/eks/flyte_aws_scheduler_helm_generated.yaml
#	deployment/eks/flyte_helm_controlplane_generated.yaml
#	deployment/eks/flyte_helm_generated.yaml
#	deployment/gcp/flyte_helm_controlplane_generated.yaml
#	deployment/gcp/flyte_helm_generated.yaml
#	deployment/sandbox-binary/flyte_sandbox_binary_helm_generated.yaml
#	deployment/sandbox/flyte_helm_generated.yaml
Signed-off-by: Ulbrich Robert <[email protected]>
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 36.31%. Comparing base (881d7a2) to head (fd840de).

Files with missing lines Patch % Lines
flyteadmin/cmd/entrypoints/migrate.go 0.00% 9 Missing ⚠️
flyteadmin/pkg/repositories/config/seed_data.go 0.00% 5 Missing ⚠️
...min/pkg/runtime/mocks/mock_application_provider.go 0.00% 4 Missing ⚠️
...teadmin/pkg/runtime/application_config_provider.go 0.00% 2 Missing ⚠️
flyteadmin/pkg/server/initialize.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5806      +/-   ##
==========================================
- Coverage   36.31%   36.31%   -0.01%     
==========================================
  Files        1304     1304              
  Lines      110072   110085      +13     
==========================================
+ Hits        39974    39977       +3     
- Misses      65936    65946      +10     
  Partials     4162     4162              
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.56% <0.00%> (-0.04%) ⬇️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.26% <ø> (+0.04%) ⬆️
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 41.91% <ø> (ø)
unittests-flytestdlib 55.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant