Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add css styling #5803

Merged
merged 2 commits into from
Oct 3, 2024
Merged

Conversation

cosmicBboy
Copy link
Contributor

This ports over a bunch of styles from docs.union.ai so that the appearance is more similar

Copy link

codecov bot commented Oct 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.32%. Comparing base (0198e91) to head (c920121).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           nielsb/docs-overhaul-flyteidl    #5803   +/-   ##
==============================================================
  Coverage                          36.31%   36.32%           
==============================================================
  Files                               1304     1304           
  Lines                             110072   110048   -24     
==============================================================
- Hits                               39971    39970    -1     
+ Misses                             65939    65922   -17     
+ Partials                            4162     4156    -6     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.61% <ø> (+0.04%) ⬆️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (-0.05%) ⬇️
unittests-flyteidl 7.12% <ø> (-0.01%) ⬇️
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller 41.93% <ø> (+0.01%) ⬆️
unittests-flytestdlib 55.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Niels Bantilan <[email protected]>
Signed-off-by: Niels Bantilan <[email protected]>
@cosmicBboy cosmicBboy merged commit efca412 into nielsb/docs-overhaul-flyteidl Oct 3, 2024
47 of 49 checks passed
@cosmicBboy cosmicBboy deleted the nielsb/css-styling branch October 3, 2024 20:39
cosmicBboy added a commit that referenced this pull request Oct 3, 2024
* fix flyteidl structure so it renders under /api/

Signed-off-by: Niels Bantilan <[email protected]>

* do not check in flyteidl docs

Signed-off-by: Niels Bantilan <[email protected]>

* update gitignore and unneeded conf

Signed-off-by: Niels Bantilan <[email protected]>

* add mock DOCSEARCH_API_KEY to docs test ci

Signed-off-by: Niels Bantilan <[email protected]>

* add css styling (#5803)

* add css styling

Signed-off-by: Niels Bantilan <[email protected]>

* update logo height

Signed-off-by: Niels Bantilan <[email protected]>

---------

Signed-off-by: Niels Bantilan <[email protected]>

---------

Signed-off-by: Niels Bantilan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants