-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Flyte][3][flytepropeller][Attribute Access][flytectl] Binary IDL With MessagePack #5763
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Future-Outlier <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5763 +/- ##
==========================================
- Coverage 36.31% 34.69% -1.62%
==========================================
Files 1304 991 -313
Lines 110072 85287 -24785
==========================================
- Hits 39974 29594 -10380
+ Misses 65936 52754 -13182
+ Partials 4162 2939 -1223
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
t.Run("Generic", func(t *testing.T) { | ||
literalVal := map[string]interface{}{ | ||
"x": 1, | ||
"y": "ystringvalue", | ||
} | ||
var literalType = &core.LiteralType{Type: &core.LiteralType_Simple{Simple: core.SimpleType_STRUCT}} | ||
lit, err := MakeLiteralForType(literalType, literalVal) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
@@ -559,12 +562,35 @@ func MakeLiteralForType(t *core.LiteralType, v interface{}) (*core.Literal, erro | |||
strValue = fmt.Sprintf("%.0f", math.Trunc(f)) | |||
} | |||
if newT.Simple == core.SimpleType_STRUCT { | |||
// If the type is a STRUCT, we expect the input to be a complex object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this not break if the clients or otherside have the old view of struct?
i.e, this seems backwards incompatible?
cc @EngHabu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will not break JSON string
case, since this is not a string type.
Tracking Issue
Issue #5318
Why are these changes needed?
flytectl
to create and get executions.Note: This PR includes handling of primitive types, Flyte types, and dataclasses.
What changes are proposed in this pull request?
Attribute Access
msgpack
bytes inBinary Literal
.Binary Literal
.flytectl
flytectl
, serialize it tomsgpack
bytes and create a binary scalar directly.This version is more concise, avoids redundant words, and clarifies the structure a bit.
How was this patch tested?
Attribute Access
unit tests and remote execution
flytectl
command line
get_task.yaml
Setup process
single binary
Screenshots
Local Execution
Remote Execution
Check all the applicable boxes