-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beacuse flyte-binary image has no version tag, it is replaced with fl… #5749
base: master
Are you sure you want to change the base?
beacuse flyte-binary image has no version tag, it is replaced with fl… #5749
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
…yte-binary-release for prevent confusin Signed-off-by: s.saghari <[email protected]> Signed-off-by: sorush saghari <[email protected]>
7e53322
to
9062434
Compare
@eapolinario would this change have any impact on the release process? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5749 +/- ##
=======================================
Coverage 36.21% 36.22%
=======================================
Files 1303 1303
Lines 109644 109644
=======================================
+ Hits 39710 39719 +9
+ Misses 65810 65801 -9
Partials 4124 4124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@davidmirror-ops can you help me with the failed tests? |
@sorushsaghari sure! please run |
after the make helm i heve some merge conflicts |
Signed-off-by: sorush saghari <[email protected]>
b876063
to
ff50e87
Compare
Tracking issue
Related to the discussion in Slack about the naming of the Flyte Docker image tag.
Why are the changes needed?
The current Docker image
flyte-binary
does not have a stable version tag, which leads to confusion during deployments. To prevent this, the image name is being changed toflyte-binary-release
, as agreed upon in the discussion.What changes were proposed in this pull request?
This PR proposes changing the Docker image name from
flyte-binary
toflyte-binary-release
in the Flyte Helm chart. This change ensures that a stable version tag is consistently used, reducing confusion and aligning with the team's agreed standards.Changes:
cr.flyte.org/flyteorg/flyte-binary-release
as the image repository.latest
and the pull policy toIfNotPresent
.How was this patch tested?
The changes were verified through updates to the Flyte Helm chart configuration. Further testing includes:
flyte-binary-release
image.Setup process
Screenshots
N/A
Check all the applicable boxes
Related PRs
None