Update ImageSpec documentation #5748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5748 +/- ##
==========================================
+ Coverage 36.21% 36.31% +0.09%
==========================================
Files 1303 1305 +2
Lines 109644 110019 +375
==========================================
+ Hits 39710 39949 +239
- Misses 65810 65914 +104
- Partials 4124 4156 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
neverett
requested changes
Sep 17, 2024
|
Thank you @pingsutw! This is going to be very helpful |
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
Co-authored-by: Nikki Everett <[email protected]> Signed-off-by: Kevin Su <[email protected]>
|
@neverett thanks for the review. I've updated the PR. Mind taking a look again. |
neverett
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Update doc and add more examples
Preview: https://flyte--5748.org.readthedocs.build/en/5748/user_guide/customizing_dependencies/imagespec.html