Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce more generous resource requests and remove duplicate file #5602

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

davidmirror-ops
Copy link
Contributor

Tracking issue

Why are the changes needed?

In line with some of the observations documented in the docs and as a response to multiple users hitting memory limits quickly on the single binary, this PR introduces more generous resource requests for this Pods.
Limits are not specified to as they could affect scheduling and influence the behavior on empyDir volumes used by Flyte. (ref)

What changes were proposed in this pull request?

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.17%. Comparing base (30d3314) to head (aebea7f).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5602      +/-   ##
==========================================
+ Coverage   35.90%   36.17%   +0.27%     
==========================================
  Files        1301     1302       +1     
  Lines      109419   109428       +9     
==========================================
+ Hits        39287    39589     +302     
+ Misses      66035    65702     -333     
- Partials     4097     4137      +40     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.31% <ø> (+1.58%) ⬆️
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.28% <ø> (ø)
unittests-flyteidl 7.09% <ø> (ø)
unittests-flyteplugins 53.31% <ø> (ø)
unittests-flytepropeller 41.72% <ø> (-0.03%) ⬇️
unittests-flytestdlib 55.35% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

neverett
neverett previously approved these changes Aug 9, 2024
Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: davidmirror-ops <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants