Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commit status notifications: Add optional prefix to commit status key #340

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bcarrier92
Copy link

@bcarrier92 bcarrier92 commented Mar 2, 2022

This PR aims to extend the functionality of commit status notifications. It adds an optional key commitStatusPrefix to the Provider spec so that notification controllers in different environments don't overwrite a commit status for a particular resource.

Example use-case: a single object (kustomization/k8s-gitops) is deployed to multiple clusters. Specifying this (e.g. to the name of the cluster) ensures that the notification controllers on each cluster don't overwrite each others' commit statuses when reporting on kustomization/k8s-gitops.

@bcarrier92 bcarrier92 force-pushed the add-optional-meta-info-to-commit-status branch 2 times, most recently from 1b013ca to 7b7ffe8 Compare March 2, 2022 21:30
@bcarrier92 bcarrier92 changed the title Commit status notifications: Add optional prefix to commit status identifier Commit status notifications: Add optional prefix to commit status key Mar 2, 2022
This commit aims to extend the functionality of commit status
notifications. It adds an optional key `commitStatusPrefix` to the
Provider spec so that notification controllers in different
environments don't overwrite a commit status for a particular resource.

Example use-case: a single object (kustomization/k8s-gitops) is deployed to
multiple clusters. Specifying this (e.g. to the name of the cluster)
ensures that the notification controllers on each cluster don't
overwrite each others' commit statuses when reporting on
kustomization/k8s-gitops.

Signed-off-by: bcarrier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant